Add contextual error #132

Shourya742 · 2025-12-12T12:36:01Z

I closed earlier PR by mistake and removed all the commits: #86.

Shourya742 · 2025-12-12T12:37:48Z

@plebhash I’ve adapted the pool according to what we discussed. Let me know what you think. I’ll handle the JDC and Tproxy updates next in this PR.

pool-apps/pool/src/lib/error.rs

plebhash · 2025-12-13T14:00:08Z

@plebhash I’ve adapted the pool according to what we discussed. Let me know what you think. I’ll handle the JDC and Tproxy updates next in this PR.

looks good to me

GitGab19

I just started the review, but I prefer to have some replies from you before proceeding with the rest, to be sure I got the idea behind the Source introduced here.

miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs

lucasbalieiro · 2025-12-18T19:02:25Z

Started a testing session with the changes of this PR.

miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs

miner-apps/jd-client/src/lib/channel_manager/extensions_message_handler.rs

miner-apps/jd-client/src/lib/channel_manager/jd_message_handler.rs

miner-apps/jd-client/src/lib/channel_manager/template_message_handler.rs

miner-apps/jd-client/src/lib/channel_manager/upstream_message_handler.rs

miner-apps/jd-client/src/lib/error.rs

miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs

miner-apps/jd-client/src/lib/channel_manager/jd_message_handler.rs

miner-apps/jd-client/src/lib/channel_manager/upstream_message_handler.rs

GitGab19 · 2026-01-09T13:27:41Z

miner-apps/jd-client/src/lib/channel_manager/upstream_message_handler.rs

+                                            messages_results
+                                                .push(Err(JDCError::disconnect(e, *downstream_id)));


Shouldn't this be shutdown?

It seems an internal error

miner-apps/jd-client/src/lib/downstream/mod.rs

GitGab19 · 2026-01-09T13:32:01Z

miner-apps/jd-client/src/lib/job_declarator/message_handler.rs

+            return Err(JDCError::fallback(
+                JDCErrorKind::UpstreamMessageDuringSoloMining,
+            ));


What happens if we fallback while we're already doing SOLO mining?

This gonna never happen, if it does, we just disconnect from the upstream entity. Should I just remove this?

JDC sets up its mode based on SetupConnection.Success flag which is wrong, fix it.

miner-apps/translator/src/lib/sv1/downstream/downstream.rs

miner-apps/translator/src/lib/sv2/channel_manager/channel_manager.rs

miner-apps/translator/src/lib/sv2/channel_manager/mining_message_handler.rs

miner-apps/translator/src/lib/sv2/upstream/upstream.rs

pool-apps/pool/src/lib/channel_manager/mining_message_handler.rs

GitGab19 · 2026-01-13T11:17:11Z

@Shourya742 can you improve the commit history?

Especially 99bfbf0 and 98e1546 commit messages.

GitGab19 · 2026-01-13T11:19:04Z

A part from this, I want to report that I ran many manual tests locally, and I haven't noticed anything weird.

So green light on my side, once the commits are better organized.

GitGab19

tACK

plebhash reviewed Dec 12, 2025

View reviewed changes

pool-apps/pool/src/lib/error.rs Outdated Show resolved Hide resolved

Shourya742 force-pushed the 2025-12-12-add-contextual-error branch from 0c2036e to a898fa1 Compare December 13, 2025 11:48

Shourya742 marked this pull request as ready for review December 14, 2025 15:50

plebhash approved these changes Dec 16, 2025

View reviewed changes

Shourya742 force-pushed the 2025-12-12-add-contextual-error branch 2 times, most recently from 90d442c to 31504fc Compare December 17, 2025 10:15

GitGab19 reviewed Dec 18, 2025

View reviewed changes

lucasbalieiro reviewed Dec 18, 2025

View reviewed changes

miner-apps/jd-client/src/lib/channel_manager/downstream_message_handler.rs Outdated Show resolved Hide resolved

Shourya742 force-pushed the 2025-12-12-add-contextual-error branch 2 times, most recently from 579ae19 to 7446ef0 Compare December 23, 2025 10:14